Declarations only required ParseResults #1150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheAngryByrd
commented
Jul 28, 2023
| let openFilesToCheckedDeclarations = | ||
| openFilesToCheckedFilesResults | ||
| let openFilesToDeclarations = | ||
| openFilesToParsedResults |
| @@ -1453,16 +1453,16 @@ type AdaptiveFSharpLspServer | |||
| |> AsyncAVal.forceAsync | |||
|
|
|||
|
|
|||
| let openFilesToCheckedDeclarations = | |||
| openFilesToCheckedFilesResults | |||
| let openFilesToDeclarations = | |||
There was a problem hiding this comment.
Renames to compensate
TheAngryByrd
force-pushed
the
folding-range-only-needs-parse
branch
from
09c7a10
to
8ab53f5
Compare
baronfel
approved these changes
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
🤖 Generated by Copilot at 09c7a10
Improve document and workspace symbol features by using parsed results of open files. Rename and update some fields and functions in
AdaptiveFSharpLspServer.fsto reflect this change.🤖 Generated by Copilot at 09c7a10
📄🗂️🐛
WHY
Discussed in #1149 (comment)
HOW
🤖 Generated by Copilot at 09c7a10
openFilesToCheckedDeclarationsandgetAllDeclarationstoopenFilesToDeclarationsandgetAllOpenDeclarationsrespectively, to reflect that they are based on parsed results of open files, not checked results (link)getDeclarationsandworkspaceSymbolfunctions to use the renamed values and avoid using potentially outdated or missing values (link, link)