Remove older impls #1174
Merged
Remove older impls #1174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheAngryByrd
commented
Oct 10, 2023
src/FsAutoComplete/Parser.fs
Outdated
| @@ -154,7 +154,7 @@ module Parser = | |||
|
|
|||
| let sourceTextFactory: ISourceTextFactory = | |||
| match sourceTextFactoryOption with | |||
| | SourceTextFactoryOptions.NamedText -> new NamedTextFactory() | |||
| | SourceTextFactoryOptions.NamedText -> new RoslynSourceTextFactory() | |||
There was a problem hiding this comment.
Left in the old parameters for now. Need to test removing these.
yeah, I think so. |
That's fine; let's do it in separate PR, and focus this one on just removing things. |
TheAngryByrd
force-pushed
the
remove-older-impls
branch
from
11a59a0
to
6a29581
Compare
TheAngryByrd
force-pushed
the
remove-older-impls
branch
from
da0df4a
to
dbfe84d
Compare
nojaf
pushed a commit
to nojaf/FsAutoComplete
that referenced
this pull request
Nov 3, 2023
* Remove NamedText implementation * 馃 Remove FsAutoComplete.Lsp * Fix codefix scaffolding * formatting * Remove unused State/Commands * Cleanup RoslynSourceText * Remove SourceText CLI option
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
馃 Generated by Copilot at 0919866
Removed the
NamedTexttype and related code from the project and replaced it with more efficient and consistent source text implementations. Simplified the LSP server implementation and the code fix scaffolding process. Updated the documentation and tests accordingly.馃 Generated by Copilot at 0919866
馃殌馃Ч馃摑
WHY
We've been running on newer implementations for a while and seems to be time to clean up older implementations.
Should I also remove any of the "seams" I put in like
IFSACSourceText?I also haven't refactored AdaptiveLSP just yet.
HOW
馃 Generated by Copilot at 0919866
NamedTexttype and its dependencies from the code base, replacing it with theRoslynSourceTexttype that implements theIFSACSourceTextinterface more efficiently and consistently (link, link, link, link, link)FsAutoComplete.Lsp.fsfile and theFSharpLspServertype, and using theAdaptiveFSharpLspServertype instead (link, link, link, link, link, link, link, link, link)FsAutoComplete.Lsp.fsfile from the registration of the code fix (link, link, link, link, link, link, link)HelpersTestsand theTestsmodules in thetest/FsAutoComplete.Tests.Lspproject to take atextFactoryargument of typeISourceTextFactoryto allow testing different implementations of theIFSACSourceTextinterface (link, link, link, link, link, link, link)initNamedTextandaddToNamedTextfunctions from theHelpersmodule in the./benchmarks/SourceTextBenchmarks.fsfile, and the irrelevantNamed_Text_changeText_everyUpdatebenchmark from theSourceText_LineChanges_Benchmarkstype in the same file (link, link, link)