Dotnet 8 builds #1175
Merged
Dotnet 8 builds #1175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheAngryByrd
force-pushed
the
dotnet-8-previews
branch
4 times, most recently
from
19fb4db
to
9482101
Compare
TheAngryByrd
force-pushed
the
dotnet-8-previews
branch
from
9482101
to
643def3
Compare
|
Hmm looks like 8rc2 is broke with tools dotnet/sdk#35989 Guess we'll try rc3. |
baronfel
reviewed
Oct 22, 2023
baronfel
reviewed
Oct 22, 2023
baronfel
reviewed
Oct 22, 2023
|
@TheAngryByrd I think I've fixed the fantomas problems - they were actually because while fantomas did have a RollForward of |
baronfel
approved these changes
Oct 29, 2023
nojaf
pushed a commit
to nojaf/FsAutoComplete
that referenced
this pull request
Nov 3, 2023
Co-authored-by: Chet Husk <baronfel@users.noreply.github.com> Co-authored-by: Chet Husk <chusk3@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
🤖 Generated by Copilot at 511ea16
This pull request updates the project to support the experimental
net8.0target framework, using a new environment variableBuildNet8to control the compilation. It also fixes some JSON and line ending issues, removes unused tools, and updates dependencies.🤖 Generated by Copilot at 511ea16
🎯🛠️🧪
WHY
Might as well see what CI says.
HOW
🤖 Generated by Copilot at 511ea16
fake-cliandoctonavtools and updatepakettool to version8.0.0-alpha002in.config/dotnet-tools.json(link).config/dotnet-tools.json(link)labelvalues fordotnet-versionmatrix in.github/workflows/build.ymland.github/workflows/test.ymlto reflect current .NET versions (link, link)BuildNet8environment variable to.github/workflows/build.ymland.github/workflows/test.ymlto enable conditional compilation ofnet8.0target framework (link, link)net8.0toframeworkvalues inpaket.dependenciesto allowpaketto resolve dependencies fornet8.0target framework (link, link)System.Security.Cryptography.Pkcspackage topaket.dependenciesto fix runtime error when usingnet8.0target framework (link)NuGet.Versioning,NuGet.Common, andNuGet.Protocolpackages toBuildgroup inpaket.dependenciesto enable querying NuGet feed inbuild.fsxscript (link)net8.0toTargetFrameworksvalues insrc/FsAutoComplete.Core/FsAutoComplete.Core.fsproj,src/FsAutoComplete.Logging/FsAutoComplete.Logging.fsproj,src/FsAutoComplete/FsAutoComplete.fsproj, andtest/FsAutoComplete.Tests.Lsp/FsAutoComplete.Tests.Lsp.fsproj, with a condition that checksBuildNet8environment variable (link, link, link, link)