Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1186 json serializer crash server #1189

Merged

Conversation

TheAngryByrd
Copy link
Member

@TheAngryByrd TheAngryByrd commented Oct 28, 2023

WHAT

πŸ€– Generated by Copilot at 1f36429

This pull request updates the LSP server implementation to use the latest version of Ionide.LanguageServerProtocol and StreamJsonRpc, and adds a custom error handler for the JsonRpc communication. These changes fix a bug, improve the features, and increase the reliability of the LSP server.

πŸ€– Generated by Copilot at 1f36429

LSP server
JsonRpc errors handled
Winter bug fixes

πŸ›πŸš€πŸ› οΈ

WHY

Fixes #1186

HOW

πŸ€– Generated by Copilot at 1f36429

  • Update Ionide.LanguageServerProtocol dependency to fix request cancellation bug (link in paket.dependencies)

@TheAngryByrd TheAngryByrd force-pushed the 1186-json-serializer-crash-server branch from 1f36429 to a41df62 Compare October 28, 2023 18:04
@TheAngryByrd TheAngryByrd force-pushed the 1186-json-serializer-crash-server branch from a41df62 to 0976d7c Compare October 28, 2023 18:13
@TheAngryByrd TheAngryByrd enabled auto-merge (squash) October 28, 2023 18:13
@TheAngryByrd TheAngryByrd merged commit 6c27a03 into ionide:main Oct 28, 2023
8 of 9 checks passed
nojaf pushed a commit to nojaf/FsAutoComplete that referenced this pull request Nov 3, 2023
* Update LSP library

* Port JsonSerializationException for JsonRpc overrides
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Neovim, Lsp Mode Crashed, range not found in JSON, diagnostics related
2 participants