Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completion command ignoring prefix text #9

Closed
Krzysztof-Cieslak opened this issue May 27, 2015 · 9 comments
Closed

Completion command ignoring prefix text #9

Krzysztof-Cieslak opened this issue May 27, 2015 · 9 comments

Comments

@Krzysztof-Cieslak
Copy link
Member

Let's say I've written Sy in editor and requested completion. From FSharp.Autocomplete I'm getting list of all possible completions (as nothing was written) instead of getting those completions which starts with (or contains) Sy. Is that by-design behavior? Or am I doing something wrong with it? Or we should try to change it?

Also maybe it would be nice to add Gitter room for this project? It could be good place to ask similar questions. (Or we can use F# slack channel but I'm not sure if all contributors / maintainers / people doing editor support are there, regularly I've been seeing there @rojepp, @kjnilsson and @7sharp9 )

@7sharp9
Copy link
Contributor

7sharp9 commented May 27, 2015

I would say this is a bug, what input do you give autocomplete? Line,col, linestr

I would add a test here if there is not one already, if it fails the test for Sy$ then it gives us something to fix. If it passes then there must be an issue with receiving the input ...

On 27 May 2015, at 19:34, Krzysztof Cieślak notifications@github.com wrote:

Let's say I've written Sy in editor and requested completion. From FSharp.Autocomplete I'm getting list of all possible completions (as nothing was written) instead of getting those completions which starts with (or contains) Sy. Is that by-design behavior? Or am I doing something wrong with it? Or we should try to change it?

Also maybe it would be nice to add Gitter room for this project? It could be good place to ask similar questions. (Or we can use F# slack channel but I'm not sure if all contributors / maintainers / people doing editor support are there, regularly I've been seeing there @rojepp, @kjnilsson and @7sharp9 )


Reply to this email directly or view it on GitHub.

@Krzysztof-Cieslak
Copy link
Member Author

@7sharp9, The input for completion command is file name, line and column.

@rneatherway
Copy link
Contributor

I'm happy to use slack or gitter, either is fine. I will try to remember to logon. @7sharp9 , the linestr stuff is handled by FSAC, editors provide just a location. @Krzysztof-Cieslak the behaviour is deliberate so that if you backspace during a completion (so that more candidates match the new shorter prefix) then more options can be displayed.

@ReedCopsey
Copy link

@Krzysztof-Cieslak Slack channel was setup for editor discussions, which could help reduce noise on some of the other channels: https://fsharp.slack.com/messages/editor_support/

Any FSSF member (which is free and easy to sign up) should have access.

@7sharp9
Copy link
Contributor

7sharp9 commented May 27, 2015

@Krzysztof-Cieslak Ah, in XS we pass the current line too so the indent island and partial island can be used.

@rneatherway
Copy link
Contributor

@7sharp9 FSAC knows about the whole file so it does the island cracking for you and passes the linestr into FCS.

@7sharp9
Copy link
Contributor

7sharp9 commented May 27, 2015

Yeah but if you have just typed Sy and hit Ctrl TAB does it know about the dirty file at that point?

@rneatherway
Copy link
Contributor

In Emacs I send the file contents before every command, so yes. Maybe not all the editors do though. I should do some docs to set expectations like that.

@rneatherway
Copy link
Contributor

Fixed by #10

vasily-kirichenko pushed a commit to vasily-kirichenko/FsAutoComplete that referenced this issue Oct 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

4 participants