Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Ionide.LanguageServerProtocol dependency #948

Merged
merged 2 commits into from May 26, 2022

Conversation

Booksbaum
Copy link
Contributor

Updates Ionide.LanguageServerProtocol to newest version (0.4.1)

(just adjustments to make it compile -- nothing further (for example: textDocument/documentSymbol still uses SymbolInformation instead of newer and recommended DocumentSymbol))

But there are two issues regarding InlayHints that are now fixed in ionide/LSP (1, 2), but came after 0.4.1 -> PR here marked as WIP
@baronfel: can you release a new Ionide.LanguageServerProtocol Version? (hopefully this time everything is in correct place 馃槄) Thanks

@baronfel
Copy link
Contributor

oh yeah, can do that today or tomorrow.

@baronfel
Copy link
Contributor

Ionide.LanguageServerProtocol 0.4.2 is indexing on nuget now!

@Booksbaum
Copy link
Contributor Author

Excellent. Thanks!

@Booksbaum Booksbaum marked this pull request as ready for review May 26, 2022 18:47
@Booksbaum
Copy link
Contributor Author

And updated in here too
-> ready to merge

@baronfel baronfel merged commit 5883bce into ionide:main May 26, 2022
@Booksbaum Booksbaum deleted the UpdateLSP branch May 26, 2022 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants