Ensure the destination directory exist when adding a new file #991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MangelMaxime
changed the title
|
Oops I just saw that there was already a PR marked as draft here: #872 But it seems like there was still a bug if adding file above or below. My current PR seems to cover all the cases: Adding new file above/below inside a directory ✅add_file_with_folder_below_above_demo.mp4Adding new file with new directory name above/below a file already inside a directory ✅Naming is hard... add_file_with_folder_below_above_demo_2.mp4 |
MangelMaxime
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to ionide/ionide-vscode-fsharp#1640
add_file_with_folder_demo.mp4