Fix Tests for AdaptiveLspServer #1053
Conversation
TheAngryByrd
force-pushed
the
adaptive-tests
branch
from
fed4f3e
to
c533543
Compare
TheAngryByrd
force-pushed
the
adaptive-tests
branch
from
c533543
to
515c95a
Compare
TheAngryByrd
force-pushed
the
adaptive-tests
branch
from
515c95a
to
4e9465a
Compare
|
That looks really amazing :-) |
Incorporated from [fix](https://github.com/fsharp/FsAutoComplete/pull/1053/files#diff-febb2875fef94d7a7c78c5c23943057bc820a1f6b672f7357aee2502b51806e0R1004-R1013) in ionide#1053 (see ionide#1037 (comment)) Co-authored-by: Jimmy Byrd <jimmybyrd@gmail.com>
Incorporated from [fix](https://github.com/fsharp/FsAutoComplete/pull/1053/files#diff-febb2875fef94d7a7c78c5c23943057bc820a1f6b672f7357aee2502b51806e0R1004-R1013) in ionide#1053 (see ionide#1037 (comment)) Co-authored-by: Jimmy Byrd <jimmybyrd@gmail.com>
TheAngryByrd
force-pushed
the
adaptive-tests
branch
from
ffe7026
to
dc22290
Compare
TheAngryByrd
force-pushed
the
adaptive-tests
branch
3 times, most recently
from
c03ed95
to
924d341
Compare
| for file in System.IO.Directory.EnumerateFiles(path, "*.fsproj", SearchOption.AllDirectories) do | ||
| do! file |> Path.GetDirectoryName |> dotnetRestore |
There was a problem hiding this comment.
We weren't doing restore properly for anything that contained subfolders with fsprojs
net 7 windows has problems running tests, hope this helps diagnose it
TheAngryByrd
force-pushed
the
adaptive-tests
branch
from
7c1e2ee
to
37939ba
Compare
| fun toolsPath -> | ||
| if projectGraphEnabled then | ||
| Ionide.ProjInfo.WorkspaceLoaderViaProjectGraph.Create(toolsPath, ProjectLoader.globalProperties) | ||
| else | ||
| Ionide.ProjInfo.WorkspaceLoader.Create(toolsPath, ProjectLoader.globalProperties) |
There was a problem hiding this comment.
You mentioned elsewhere about passing in 'other CLI properties' to proj-info - what were you thinking about?
There was a problem hiding this comment.
Wonder if it's worth having a --msbuild-global-properties CLI flag for FSAC that you could do like MSBuildProperty=Foobar,AnotherProperty=false and pass to proj-info it's not a hardcoded list. More escape hatch kind of stuff if msbuild related stuff changes we don't have to release a fix right away if an sdk change or whatever breaks FSAC.
There was a problem hiding this comment.
ohhhhh, I see. That would be a nice addition, but to me it almost speaks to a problem in proj-info instead - we need to be able to change the global properties during runtime and re-trigger evaluation based on that. Classic example is how we hard-code Debug right now. So instead of a CLI flag I think I'd prefer a config setting in Ionide that would map to a JSON-RPC call to set specific global properties for a project, which would flow into proj-info as required. This is a bit bigger of a problem space, though.
Notable changes: