Add .NET Core to FSharp.Core nuget package

[dsyme]

The FSharp.Core nuget package is currently authored from this repo.

It would be great to start adding .NET Core versions of FSharp.Core to this nuget package, as this will make it easier for clients to use FSharp.Core.

My understanding is that Microsoft will make a package for the signed FSharp.Core we need to include, and we just need to either merge this package into FSharp.Core or list it as a dependency. I'm a bit unclear what the canonical source of this package will be

• There is this on nuget: https://www.nuget.org/packages/Microsoft.VisualFSharp.Core.Redist/
• @enricosada uses this today source https://www.myget.org/F/fsharp-daily/api/v3/, browse here.

[enricosada]

We are going to have alignment issues, a lots if we have two (or more) packages, and not from maintainer side but from develper side.

nuget support packages with multiple frameworks. we should use that and have a single FSharp.Core.

but merge different versions of assemblies in same package is a bad hack, features/bugs may change.

for example, if we add the new FSharp.Core.dll built for .NET Core to current packages, is not right, because that mean the package contains two different versions of same dll

• net46 => version 4.0.0.x
• netstandard1.5 => version built from latest commit of master branch

A packages should contain the assemblies built from same commit

[dsyme]

@enricosada Yes, agreed (the current package contains version 4.4.0.0 in net40). Note sure what to do about that since we only like to put the finalized, signed netfx FSharp.Core in the package.

We could just wait, of course, and accept that there are two FSharp.Core packages until 4.4.1.0 comes out.

[masaeedu]

So if I understand correctly, the plan is to wait until the next stable release of FSharp.Core, and distribute the NETStandard compatible bits with that? Will this mean FSharp.Core.netcore will disappear?

[masaeedu]

Also, when this does end up being released, would it be possible to target a lower .NET Standard API, e.g. 1.3? This would greatly increase the backwards compatibility of the library.

[enricosada]

ref #659

[enricosada]

done by https://www.nuget.org/packages/FSharp.Core/4.1.0

[masaeedu]

@enricosada I'm going to reiterate my request here; can this be targeted at a lower version of .NET Standard?

Right now there are barely any runtimes that support .NET Standard 1.6, and the official advice is to use 1.4 until 2.0 is ready. Additionally, many of the APIs that are available in .NET Standard 1.5 and 1.6 are going to be removed in 2.0, so you're setting yourself up for more porting work in the future. If you only use the APIs available in 1.4, you should be safe.

[dsyme]

Moving discussion to #669

[enricosada]

@masaeedu see #669 for lower version. it should be really lower. there is not a real reason atm, just need to be fixed in microsoft/visualfsharp (we use same deps, target version of Microsoft.fsharp.core.netcore package)

[masaeedu]

@enricosada Thanks. Is there an issue to watch on microsoft/visualfsharp for this or does one need to be created?

[enricosada]

@masaeedu dotnet/fsharp#2501