Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SRTP] Allow field constraints on SRTP (val) #1307

Open
5 of 6 tasks
xperiandri opened this issue Aug 24, 2023 · 1 comment
Open
5 of 6 tasks

[SRTP] Allow field constraints on SRTP (val) #1307

xperiandri opened this issue Aug 24, 2023 · 1 comment

Comments

@xperiandri
Copy link

xperiandri commented Aug 24, 2023

Allow to specify val constraints

let createErrorMessage<'Number
                when 'Number: (static val MinValue: 'Number)
                and 'Number: (static val MaxValue: 'Number)>
    (n: 'Number) =
	$"Cannot coerce {n} to integer with range from {'Number.MinValue} to {'Number.MaxValue}"

The existing way of approaching this problem in F# is not possible

Pros and Cons

The advantages of making this adjustment to F# are ability to write more generic code

The disadvantages of making this adjustment to F# are no

Extra information

Estimated cost (XS, S, M, L, XL, XXL): probably S

Related suggestions: I'm not aware of any

Affidavit (please submit!)

Please tick these items by placing a cross in the box:

  • This is not a question (e.g. like one you might ask on StackOverflow) and I have searched StackOverflow for discussions of this issue
  • This is a language change and not purely a tooling change (e.g. compiler bug, editor support, warning/error messages, new warning, non-breaking optimisation) belonging to the compiler and tooling repository
  • This is not something which has obviously "already been decided" in previous versions of F#. If you're questioning a fundamental design decision that has obviously already been taken (e.g. "Make F# untyped") then please don't submit it
  • I have searched both open and closed suggestions on this site and believe this is not a duplicate

Please tick all that apply:

  • This is not a breaking change to the F# language design
  • I or my company would be willing to help implement and/or test this

For Readers

If you would like to see this issue implemented, please click the 👍 emoji on this issue. These counts are used to generally order the suggestions by engagement.

@Happypig375
Copy link
Contributor

let inline createErrorMessage<'Number
                when 'Number: (static member MinValue: 'Number)
                and 'Number: (static member MaxValue: 'Number)>
    (n: 'Number) =
    $"Cannot coerce {n} to integer with range from {'Number.MinValue} to {'Number.MaxValue}"

compiles.

Why not let fields satisfy this constraint instead of making new syntax?

@xperiandri xperiandri changed the title Allow field constraints on SRTP (val) [SRTP] Allow field constraints on SRTP (val) Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants