Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change all links of "Archived UserVoice comments" in migrated issues to point to the commit before archive deletion instead #735

Open
Happypig375 opened this Issue Apr 13, 2019 · 0 comments

Comments

Projects
None yet
1 participant
@Happypig375
Copy link

Happypig375 commented Apr 13, 2019

Change all links of "Archived UserVoice comments" in migrated issues to point to the commit before archive deletion instead

I propose we change the links of "Archived UserVoice Comments" to point to the file in the commit d48c35c instead of master because those files are deleted in da13a85.

The existing way of approaching this problem in fslang-suggestions is to change the master in links to point to d48c35c manually.

e.g. Click "Archived UserVoice Comments" in #18. It brings up the 404 Not Found page.

This is because that link points to master where the archive is gone. If we change master to d48c35c, we can read the comments successfully.

Pros and Cons

The advantages of making this adjustment to fslang-suggestions are

  1. Links are not dead!
  2. In case UserVoice is down, people can still view comments.
  3. No need to search the commit history only to find out the archive is deleted, and need to relocate the comments again.

The disadvantage of making this adjustment to fslang-suggestions is the work needed to update links.

Extra information

Estimated cost (XS, S, M, L, XL, XXL): S

Related suggestions: Nope

Affidavit (please submit!)

Please tick this by placing a cross in the box:

  • This is not a question (e.g. like one you might ask on stackoverflow) and I have searched stackoverflow for discussions of this issue
  • I have searched both open and closed suggestions on fslang-suggestions and believe this is not a duplicate
  • This is not something which has obviously "already been decided" in previous versions of F#. If you're questioning a fundamental design decision that has obviously already been taken (e.g. "Change the syntax to C#") then please don't submit it.

Please tick all that apply:

  • This is not a breaking change to the F# language design obviously
  • I would be willing to help test this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.