Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax indentation rules on mutually recursive functions when using with CE #868

Closed
4 of 5 tasks
Swoorup opened this issue May 10, 2020 · 2 comments
Closed
4 of 5 tasks

Comments

@Swoorup
Copy link

Swoorup commented May 10, 2020

Fix indentation rules on mutually recursive functions when using with CE

Its common to write F# async workflow in the following style:

let doSth () = async {
...
}

I propose we allow writing recursive function as follows with CE at the same line as let/and definition:

let rec async1 () = async {
  return! async2 ()
}
and async2 () = async {
  return 1
}

Currently the compiler gives the error: The value or constructor 'async2' is not defined.

The existing way of approaching this problem in F# is to change the style so that async keyword appears in the next line after the let bindings.

let rec async1 () =
  async { return! async2 () }
and async2 () =
  async { return 1 }

Pros and Cons

The advantages of making this adjustment to F# are, consistent with the first example.

The disadvantages of making this adjustment to F# are none.

Extra information

Estimated cost (XS, S, M, L, XL, XXL): S-M

Related suggestions: (put links to related suggestions here)

Affidavit (please submit!)

Please tick this by placing a cross in the box:

  • This is not a question (e.g. like one you might ask on stackoverflow) and I have searched stackoverflow for discussions of this issue
  • I have searched both open and closed suggestions on this site and believe this is not a duplicate
  • This is not something which has obviously "already been decided" in previous versions of F#. If you're questioning a fundamental design decision that has obviously already been taken (e.g. "Make F# untyped") then please don't submit it.

Please tick all that apply:

  • This is not a breaking change to the F# language design
  • I or my company would be willing to help implement and/or test this
@dsyme
Copy link
Collaborator

dsyme commented May 28, 2020

Yes, this is ok, I'd be happy if we can make this relaxation

@dsyme
Copy link
Collaborator

dsyme commented Aug 24, 2021

Completed (in preview)

@dsyme dsyme closed this as completed Mar 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants