Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow geom_vline() behind points? #84

Closed
leeper opened this issue Jun 26, 2018 · 1 comment
Closed

Allow geom_vline() behind points? #84

leeper opened this issue Jun 26, 2018 · 1 comment

Comments

@leeper
Copy link

leeper commented Jun 26, 2018

It would be awesome if it were possible to draw the geom_vline() behind the points and error bars. At present, it has to be added as a subsequent layer which makes it the topmost layer, which I find aesthetically unsatisfying.

I think you could simply add a vline = NULL default argument and then change these lines to:

        p <- ggplot(df, aes(x = estimate, xmin = conf.low, xmax = conf.high,
                            y = stats::reorder(term, y_ind), colour = model)) +
            vline + 
            do.call(ggstance::geom_pointrangeh, point_args) +
            ylab("") + xlab("")

By default then, nothing would be drawn but users could pass their own geom_vline() object in place.

@fsolt fsolt closed this as completed in 63b4a94 Jun 26, 2018
@fsolt
Copy link
Owner

fsolt commented Jun 26, 2018

Thanks, Thomas!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants