Skip to content
This repository has been archived by the owner on Oct 31, 2021. It is now read-only.

Recommended changes resulting from automated audit #5

Open
6 tasks
Jericho opened this issue Jun 5, 2018 · 2 comments
Open
6 tasks

Recommended changes resulting from automated audit #5

Jericho opened this issue Jun 5, 2018 · 2 comments

Comments

@Jericho
Copy link

Jericho commented Jun 5, 2018

We performed an automated audit of your Cake addin and found that it does not follow all the best practices.

We encourage you to make the following modifications:

  • You are currently referencing Cake.Core 0.18.0. Please upgrade to 0.28.0
  • You are currently referencing Cake.Common 0.18.0. Please upgrade to 0.28.0
  • The Cake.Core reference should be private. Specifically, your addin's .csproj should have a line similar to this: <PackageReference Include="Cake.Core" Version="0.28.0" PrivateAssets="All" />
  • The Cake.Common reference should be private. Specifically, your addin's .csproj should have a line similar to this: <PackageReference Include="Cake.Common" Version="0.28.0" PrivateAssets="All" />
  • Your addin should target netstandard2.0. Please note that there is no need to multi-target, netstandard2.0 is sufficient.
  • The nuget package for your addin should use the cake-contrib icon. Specifically, your addin's .csproj should have a line like this: <PackageIconUrl>https://cdn.rawgit.com/cake-contrib/graphics/a5cf0f881c390650144b2243ae551d5b9f836196/png/cake-contrib-medium.png</PackageIconUrl>.

Apologies if this is already being worked on, or if there are existing open issues, this issue was created based on what is currently published for this package on NuGet.org and in the project on github.

@wallymathieu
Copy link
Collaborator

Yes, these would be nice to fix. Perhaps something that a small pull request could help with?

@Jericho
Copy link
Author

Jericho commented Apr 20, 2019

We performed a follow up automated audit of your Cake addin and found that some (or all) issues previously identified have not been resolved.

We strongly encourage you to make the modifications previously highlighted.

Apologies if this is already being worked on, or if there are existing open issues, this issue was created based on what is currently published for this package on NuGet.

This comment was created by a tool: Cake.AddinDiscoverer version 3.12.1

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants