Skip to content
This repository has been archived by the owner on Oct 31, 2021. It is now read-only.

[Highlight reference & Rename refactoring] Not all identifiers are highlighted/refactored with pattern matching #139

Closed
OkayX6 opened this issue Mar 9, 2014 · 3 comments · Fixed by #144
Closed

[Highlight reference & Rename refactoring] Not all identifiers are highlighted/refactored with pattern matching #139

OkayX6 opened this issue Mar 9, 2014 · 3 comments · Fixed by #144
Labels
bug upstream

Comments

@OkayX6
Copy link
Contributor

OkayX6 commented Mar 9, 2014

All expr identifiers should be highlighted.
As such, rename refactoring only renames the highlighted identifiers.

image
@vasily-kirichenko
Copy link
Contributor

Could you please add a failing test here https://github.com/fsprojects/VisualFSharpPowerTools/blob/master/tests/FSharpVSPowerTools.Core.Tests/LanguageServiceTests.fs ?

@OkayX6 OkayX6 mentioned this issue Mar 9, 2014
Merged
@dungpa
Copy link
Contributor

dungpa commented Mar 12, 2014

Reopen since it is probably an upstream bug which should be reported in FCS.

@dungpa dungpa reopened this Mar 12, 2014
@dungpa dungpa mentioned this issue Mar 13, 2014
Closed
@vasily-kirichenko
Copy link
Contributor

Fixed via #216

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug upstream
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add failing test for highlight usage
3 participants
@vasily-kirichenko @dungpa @OkayX6