[Highlight usages] Generic parameters are not highlighted properly

[vasily-kirichenko]

This is how the C# editor highlights generic parameters:


This is how the add-in works:

[OkayX6]

Question: shouldn't we have the plug-in highlight the single quote as part of the generic type symbol too?

[dungpa]

Yes, we should highlight single quotes in 'T and 'P. The issue is that VS doesn't automatically select them as words. We need to manipulate spans using the lexer and update references from F.C.S.

@vasily-kirichenko Could you please check whether we get all the references for type variables by using F.C.S 0.0.20?

[vasily-kirichenko]

I checked this on the master (which uses 0.0.20 now).
For line:

type C<'a> = C of 'a

the following call (we "place" the cursor inside the first 'a):

CheckFileResults.GetSymbolAtLocation(15, 9, "type C<'a> = C of 'a", ["'a"])

it returns None.
If we place the cursor on the second 'a:

CheckFileResults.GetSymbolAtLocation(15, 20, "type C<'a> = C of 'a", ["'a"])

we get a Some(symbol), then we are trying to get the refs for it:

CheckProjectResults.GetUsesOfSymbol(symbol)

results:

So, we can highlight the second 'a occurrence only:

[7sharp9]

It would be good to get type parameter highlighting in XS too.

[dungpa]

We are altering findLongIdent by GetLongIdent function based on the lexer, which correctly identifies type parameters. When this issue is resolved, one can pull the changes to FSharpBinding easily.

[ghost]

Should be fixed in FCS 0.0.22

[vasily-kirichenko]

Yes, it fixed after updating to 0.0.22 here #97

Thanks!