Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide inherited parameters that are hidden #84

Merged
merged 3 commits into from Jun 26, 2017
Merged

Hide inherited parameters that are hidden #84

merged 3 commits into from Jun 26, 2017

Conversation

agross
Copy link
Contributor

@agross agross commented Jun 26, 2017

Seems like Paket's way of displaying subcommand help is a bit special, hence the test that might appear too complex. (Paket uses the subcommand's parser to display help.)

#80


I'm still having build problems. I didn't commit the changes that were introduced by paket update to enable a local build.

@eiriktsarpalis
Copy link
Member

lgtm. I won't have time to investigate why the builds are failing in the near future, I welcome contributations towards that goal though.

@agross
Copy link
Contributor Author

agross commented Jun 26, 2017

Will you merge & release despite the failing build?

@eiriktsarpalis
Copy link
Member

How could I release? It's not building in CI or my machine

@agross
Copy link
Contributor Author

agross commented Jun 26, 2017

I was at least able to fix the AppVeyor and local builds. Travis fails with an error that I have no idea about how to fix it.

@eiriktsarpalis
Copy link
Member

thanks

@eiriktsarpalis eiriktsarpalis merged commit 17f6530 into fsprojects:master Jun 26, 2017
@forki
Copy link
Member

forki commented Jun 26, 2017

@eiriktsarpalis could you please release it? it would unblock paket. thx

@eiriktsarpalis
Copy link
Member

@forki the repo is not building on my machine. I can give you ownership of the nuget package if you're in a hurry.

@forki
Copy link
Member

forki commented Jun 27, 2017

That could work.
But what's the problem?

@eiriktsarpalis
Copy link
Member

I have no idea. It's caused by .NET core crap, obviously.

dotnet "restore" "C:\Users\eirik.tsarpalis\devel\public\Argu\src\Argu\project.json"
C:\Users\eirik.tsarpalis\devel\public\Argu\src\Argu\project.json(1,1): error MSB4025: The project file could not be loaded. Data at the root level is invalid. Line 1, position 1.
Running build failed.
Error:
System.Exception: Restore failed on "restore" "C:\Users\eirik.tsarpalis\devel\public\Argu\src\Argu\project.json"

I've added you as owner to the nuget package.

@agross
Copy link
Contributor Author

agross commented Jun 29, 2017

That extra line in global.json in this PR fixed that error for me. Did you try to build the PR branch or master?

@eiriktsarpalis
Copy link
Member

which PR?

@agross
Copy link
Contributor Author

agross commented Jun 29, 2017

This one here.

@agross agross deleted the fix-80 branch June 29, 2017 10:36
@eiriktsarpalis
Copy link
Member

I built the latest master, so the assumption is that it's incorporated the changes.

@forki
Copy link
Member

forki commented Jul 4, 2017

I've added you as owner to the nuget package.

I didn't get a request mail. Can you please retry?

@eiriktsarpalis
Copy link
Member

@forki what about now? You're sforkmann right?

@forki
Copy link
Member

forki commented Jul 10, 2017

unfortunately I did not get any invitation mails. @maartenba do you know if there is a site at nuget.org where I can see my invitations? Can't find it

@maartenba
Copy link

I don't believe there is. Athough https://www.nuget.org/packages/{packagename}/ManagePackageOwners (in this case: https://www.nuget.org/packages/Argu/ManagePackageOwners ) may do the trick.

@forki
Copy link
Member

forki commented Jul 10, 2017

ERR_TOO_MANY_REDIRECTS ;-)

@eiriktsarpalis
Copy link
Member

Trying a third time, this is what it currently looks like

capture

@forki
Copy link
Member

forki commented Jul 10, 2017

now it worked! magic! thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants