Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NuGet package data file location #6

Closed
n7581769 opened this issue Sep 22, 2023 · 1 comment
Closed

NuGet package data file location #6

n7581769 opened this issue Sep 22, 2023 · 1 comment
Assignees

Comments

@n7581769
Copy link
Collaborator

Previously, when building the package for NuGet, the files with the lists of locations on the GenBank FTP server would be placed in the same directory as the DLLs, rather than in the data subfolder. This meant that they could not be found when using the type provider from NuGet.

At present, I have moved the files out of the subfolder to attempt to avoid this problem (though my attempt to use the package locally still did not work, for other reasons). There are a few different ways we could tackle this problem:

  • Find a way to properly put the files in the correct subfolder while letting the type provider still work as a project reference, if that's still desired;
  • Make the data files and access code a separate package, as the files can be more easily put into a subfolder this way; or
  • Remove the dependency on these data files entirely, as mentioned in Add script that updates GenBank file lists #5.
@n7581769
Copy link
Collaborator Author

n7581769 commented Oct 9, 2023

Completed in 8fd9f24 - data files are no longer included. Instead they are downloaded (from this repository using direct links) when needed by the package.

@n7581769 n7581769 closed this as completed Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant