Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C# .NET Core Port #20

Closed
kevc63 opened this issue Apr 7, 2018 · 4 comments
Closed

C# .NET Core Port #20

kevc63 opened this issue Apr 7, 2018 · 4 comments

Comments

@kevc63
Copy link

kevc63 commented Apr 7, 2018

Hello,

This is great work and that I would like to port it to C# as a .NET core project. Do you have any preference in what I should call the port and who should receive credit. I'm looking to port to C# for learning purposes, and to use on my blog.

Thanks, Kevin

@sergey-tihon
Copy link
Member

hi @kevc63, do not you want to add C# friendly API to this project and open PR with your changes?

@kevc63
Copy link
Author

kevc63 commented Apr 7, 2018

From looking at Issue #9 I'm not sure this is .NET Core compatible, and I had no luck trying to build it as that in VS 2017. I'm am not sure doing a PR and making an API will meet my needs.

@obegendi
Copy link

@sergey-tihon @kevc63 We were port this library to .net core. You can use our nuget package.
https://github.com/Hesapkurdu/hk-financial-functions

Please contribute as well. Thank you.

@jcoliz
Copy link
Member

jcoliz commented Nov 20, 2021

Hi, folks. I am cleaning up old issues. Please note that after recent changes, this library now runs on any implementation of .NET Standard 2.0. My personal recommendation is to use this library, not port it, because of the exhaustive amount of testing that has been put into it. That said, to answer the original question, please give credit to the original author Luca Bolognese https://github.com/lucabol

@jcoliz jcoliz closed this as completed Nov 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants