Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DotCover report and sendTeamCityDotNetCoverageImport #1059

Closed
kerams opened this issue Dec 28, 2015 · 4 comments
Closed

DotCover report and sendTeamCityDotNetCoverageImport #1059

kerams opened this issue Dec 28, 2015 · 4 comments

Comments

@kerams
Copy link
Contributor

kerams commented Dec 28, 2015

According to the docs, this function sends dotcover, partcover, ncover and ncover3 reports to TC using sendToTeamCity "##teamcity[importData type='dotNetCoverage' path='%s']". However, when I pass in my DotCover.dcvr, the coverage does not show up in TC. If I specify the exact tool using sendToTeamCity "##teamcity[importData type='dotNetCoverage' tool='dotcover' path='%s']", it all works fine.
Do you think this is an issue with TeamCity or FAKE?

@bjartwolf
Copy link
Contributor

@kerams I believe the dotcover mentioned in the first command is the one you get if you run the .dcvr through DotCoverReport to create an ndepend report file

Target "CreateDotCoverXmlReport" (fun _ ->
   DotCoverReport (fun p -> { p with 
                                Source = artifactsDir @@ "MSTest.dcvr"
                                Output = artifactsDir @@ "dotCoverReport.xml"
                                ReportType = DotCoverReportType.NDependXml} ) false)

I think we should clarify this in the docs and make a special .dcvr helper to do the dcvr import. I struggled with this as well.

@kerams
Copy link
Contributor Author

kerams commented Jan 11, 2016

Thanks for clearing this up. Is it only the importing of the entire snapshot (as produced by DotCoverNUnit) that requires tool='dotcover'?

@bjartwolf
Copy link
Contributor

That is my understanding, at least. And I think that is easier to do, then the CreateDotCoverXmlReport should be unnescessary.

@baronfel
Copy link
Contributor

I just got bit by this today as well. I'd be up for writing a PR that obsoletes this function, and creates a new function that provides a DU for the type of coverage tool, if people would use that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants