Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repeated (Identical) Types in Implementing Libraries #647

Closed
Gastove opened this issue Mar 5, 2021 · 3 comments
Closed

Repeated (Identical) Types in Implementing Libraries #647

Gastove opened this issue Mar 5, 2021 · 3 comments

Comments

@Gastove
Copy link

Gastove commented Mar 5, 2021

I've been working with the folk over at Fleece on some documentation updates. This has involved, among other things, updating quite a number of major versions of FSharp.Formatting.

On FSharp.Formatting 9.0.1, we're seeing a great number of repeat types. Fleece is structured as a base module that is then used in JSON-framework-specific implementations; it appears we're getting one copy of each type from the base module, then a repeat of each type for each specific implementation.

How can we reduce this down, filter out the duplicates?

Thanks very much!

@dsyme
Copy link
Contributor

dsyme commented Mar 24, 2021

Hmmmmm I'm not at all sure. Could you create some kind of minimal repro? The relevant code will be GenerateModel.fs

@dsyme
Copy link
Contributor

dsyme commented Mar 24, 2021

To be honest I'd recommend generous use of exclude tags https://github.com/fsharp/fslang-design/blob/master/tooling/FST-1031-xmldoc-extensions.md#exclude

There are multiple types of the same name in the same namespace across multiple DLLs. They should either be internal or, if really desired (which is incredibly rare), they should be explicitly excluded.

@dsyme dsyme closed this as completed Mar 24, 2021
@dsyme
Copy link
Contributor

dsyme commented Mar 24, 2021

(Closed as this is really by design for this this rare case - arguably showing the multiple types highlights a potential bug)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants