Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Q: Is there a reason why TimeSpan is not a Supported Type? #61

Open
warren-pieterse opened this issue Feb 18, 2022 · 19 comments
Open

Q: Is there a reason why TimeSpan is not a Supported Type? #61

warren-pieterse opened this issue Feb 18, 2022 · 19 comments

Comments

@warren-pieterse
Copy link

Was wondering why TimeSpan is not in the Supported Types am I missing something?

@AntyaDev
Copy link

@vsapronov +1

@petrkoutnycz
Copy link

This repo seems to be a bit abandoned :-(

@dsyme
Copy link

dsyme commented Oct 24, 2022

@petrkoutnycz I've asked here whether @vsapronov would like to move to https://github.com/fsprojects.

There is also the option of forking there unless of course @vsapronov disapproves

@dsyme
Copy link

dsyme commented Oct 24, 2022

@AntyaDev What do you think?

@AntyaDev
Copy link

Hi @petrkoutnycz , @dsyme
I did my personal fork with TimeSpan support: https://github.com/PragmaticFlow/FSharp.Json.New
Also, I think it does make sense to move it to https://github.com/fsprojects

@dsyme
Copy link

dsyme commented Oct 25, 2022

@AntyaDev Do you think you could move that, and then use something to replicate the issues across from here? It seems to make sense? Unless @vsapronov thinks we shouldn't?

I will discuss with @sergey-tihon to add policies to fsprojects with regard to this kind of fork. Obviously we do it reluctantly and would want reconvergence if there's another development stream.

@vsapronov
Copy link
Collaborator

I haven't seen any PRs for TimeSpan support. I would be glad to consider and merge it @AntyaDev.

@vsapronov
Copy link
Collaborator

@AntyaDev I have checked your fork quickly. Is my understanding right that the required changes are mostly in files from FSharp.Data for TimeSpan support?

@dsyme
Copy link

dsyme commented Oct 26, 2022

Hi all, @vsapronov is willing to transfer to fsprojects, could we have one or two volunteers for maintainership please?

@AntyaDev
Copy link

Hi @vsapronov ,
Yes, you are right.
And I think the tests were updated.

@dsyme
Copy link

dsyme commented Oct 28, 2022

@AntyaDev Could you be a co-maintainer in "fsprojects"? thanks

Or @petrkoutnycz would you be interested?

@AntyaDev
Copy link

Hi @dsyme ,

I'm afraid I will not be able to maintain it.
I just physically don't have time on other OSS projects.

@johnazariah
Copy link
Collaborator

I've never done any maintenance work in F#, but mostly because I don't know how!

I'm happy to stick my hand up and give it a try!

@tnishimura
Copy link

I can do it as well, this project is my preferred way of json-ing things in F#. (I'm @CarpeNoctemDev on twitter)

@dsyme
Copy link

dsyme commented Oct 31, 2022

Fab, let's continue here : fsprojects/.github#43 (comment)

@dsyme
Copy link

dsyme commented Nov 5, 2022

@vsapronov Per the above could you add @tnishimura and @johnazariah as co-maintainers please? I'll do it if you wish.

Also could you please add "fsprojects" as backup owner on the nuget package on nuget.org. Thanks.

@dsyme
Copy link

dsyme commented Nov 11, 2022

@tnishimura and @johnazariah - I have added you as maintainers to this repo. Please go ahead and do any of the necessary maintenance, pulls etc. Don't hold back.

@vsapronov Could you add fsprojects as co-owner on the nuget package please? https://www.nuget.org/packages/FSharp.Json, thanks! If we don't have that we'll have to do a namespace/package rename which would be unfortunate.

Thanks all!

@vsapronov
Copy link
Collaborator

@dsyme, @tnishimura and @johnazariah don't worry I will add fsprojects to nuget. Sorry it takes me long time. Multitasking here...

@dsyme
Copy link

dsyme commented Nov 11, 2022

@vsapronov @tnishimura @johnazariah OK, I've added NUGETKEY in this repo to allow publishing FSharp.Json package (and nothing else) for the next year via actions from this repo. Keys time out after 365 days, need to be regenerated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants