New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

paket pack failes if AssemblyName is empty and template type is project. #1234

Closed
trondd opened this Issue Nov 17, 2015 · 6 comments

Comments

Projects
None yet
2 participants
@trondd
Contributor

trondd commented Nov 17, 2015

paket pack failes if AssemblyName is empty and template type is file. It complains that the file can't be found, but I think it would be more useful to point to the root issue in the GetAssemblyName function in ProjectFile.fs

Paket version is 2.15.7.0

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Nov 17, 2015

Member

do you have a csproj and template file for me?

Member

forki commented Nov 17, 2015

do you have a csproj and template file for me?

@trondd

This comment has been minimized.

Show comment
Hide comment
@trondd

trondd Nov 17, 2015

Contributor

It is part of internal source code, but I'll prepare an example. Stay tuned.

Contributor

trondd commented Nov 17, 2015

It is part of internal source code, but I'll prepare an example. Stay tuned.

@trondd

This comment has been minimized.

Show comment
Hide comment
@trondd

trondd Nov 17, 2015

Contributor

See https://github.com/trondd/PaketIssue1234

paket pack output temp -v

Note that I've manually cleared the AssemblyName in the Project file.

Contributor

trondd commented Nov 17, 2015

See https://github.com/trondd/PaketIssue1234

paket pack output temp -v

Note that I've manually cleared the AssemblyName in the Project file.

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Nov 17, 2015

Member

what output would you expect? And why is the AssemblyName empty in the first place? Does it use a default?

Member

forki commented Nov 17, 2015

what output would you expect? And why is the AssemblyName empty in the first place? Does it use a default?

@forki forki added the bug label Nov 17, 2015

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Nov 17, 2015

Member

ok I can reproduce.

    Ein Teil des Pfades "C:\Users\Steffen\AppData\Local\NCrunch\4112\7\integrationtests\scenarios\i001234-missing-assemblyname\temp\PaketBug\bin\Release\.dll" konnte nicht gefunden werden.

which is your filenotfoundexception. Question is: can we improve the GetAssemblyName function? Can we use the CsProj name in this case!?

Member

forki commented Nov 17, 2015

ok I can reproduce.

    Ein Teil des Pfades "C:\Users\Steffen\AppData\Local\NCrunch\4112\7\integrationtests\scenarios\i001234-missing-assemblyname\temp\PaketBug\bin\Release\.dll" konnte nicht gefunden werden.

which is your filenotfoundexception. Question is: can we improve the GetAssemblyName function? Can we use the CsProj name in this case!?

@forki forki closed this in 4999ab6 Nov 17, 2015

@trondd

This comment has been minimized.

Show comment
Hide comment
@trondd

trondd Nov 17, 2015

Contributor

Awesome!

Contributor

trondd commented Nov 17, 2015

Awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment