Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an extension point to paket pack to specify dependancies by framework #1539

Closed
enricosada opened this issue Mar 23, 2016 · 5 comments
Closed

Comments

@enricosada
Copy link
Collaborator

to make it possibile to support dependencies by framework (like .NET Core) until #913 is ready

I think two command line arguments are enough, it's a temporary but can help a lot, and low regression (replacement/addition are done after nuspec is generated)

an example:

  • paket pack --defaultgroup net40 to put generated nuspec deps inside a group

  • paket pack --additionaldeps "path/to/file" and path/to/file contains the other groups in nuspec format

     <group targetFramework="DNXCore5.0">
        <dependency id="Microsoft.FSharp.Core.netcore" version="[1.0.0-alpha-151221, )" />
        <dependency id="NETStandard.Library" version="[1.0.0-rc2-23811, )" />
      </group>
    
@forki
Copy link
Member

forki commented Mar 23, 2016

mhm. can you come up with a syntax for paket.template instead?

@enricosada
Copy link
Collaborator Author

I dont know enough about resolution and backward compatibility to comment about paket.template syntax.
I know that's an hack, i was trying to find something safe and easy to implement
But maybe it's better to wait template support, more clean, i'll close

@forki forki reopened this Mar 23, 2016
@forki
Copy link
Member

forki commented Mar 23, 2016

Let's keep it open for discussion. I will revisit soon

@enricosada
Copy link
Collaborator Author

Dunno, probably that's not the best way, or is not ok. For sure is an hack

It's a bit selfish, but i just need something to add .NET Core framework to nuget packages created with paket pack that's my problem.
Root cause is #913 but i dont know how much work is that, and this can be wasted work
Atm is really an hack ( ref chessie fsprojects/Chessie@eef358e ) for dependencies ( unzip nuspec from nupkg, modify nuspec xml, zip back ). files are ok

Maybe some way to change the nuspec before the nupkg is created is ok too.

I can add the hack in FAKE as target, but not everyone who use paket use fake too, so it's a annoying

@enricosada
Copy link
Collaborator Author

Closing. paket.template support that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants