New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-fw targeting w/ spaces aren't being trimmed for paket.restore.cached file gen #2749

Closed
haf opened this Issue Sep 10, 2017 · 1 comment

Comments

Projects
None yet
1 participant
@haf
Member

haf commented Sep 10, 2017

➜  expecto git:(feature/netstandard1.6) dotnet build
/Users/h/dev/haf/expecto/.paket/Paket.Restore.targets(86,5): warning : Detected a change ('target-framework 'netstandard1.6'') in the project file '/Users/h/dev/haf/expecto/Expecto/Expecto.fsproj', calling paket restore [/Users/h/dev/haf/expecto/Expecto/Expecto.fsproj]
/Users/h/dev/haf/expecto/.paket/Paket.Restore.targets(90,5): error : A paket file for the framework 'netstandard1.6' is missing. Please delete 'paket-files/paket.restore.cached' and call 'paket restore'. [/Users/h/dev/haf/expecto/Expecto/Expecto.fsproj]
^CAttempting to cancel the build...

➜  expecto git:(feature/netstandard1.6) rm paket-files/paket.restore.cached
➜  expecto git:(feature/netstandard1.6) mono .paket/paket.exe restore
Paket version 5.93.0
 - /Users/h/dev/haf/expecto/Expecto/obj/Expecto.fsproj.net461.paket.resolved created
 - /Users/h/dev/haf/expecto/Expecto/obj/Expecto.fsproj. netstandard1.6.paket.resolved created
 - /Users/h/dev/haf/expecto/Expecto.BenchmarkDotNet/obj/Expecto.BenchmarkDotNet.fsproj.net461.paket.resolved created
 - /Users/h/dev/haf/expecto/Expecto.BenchmarkDotNet/obj/Expecto.BenchmarkDotNet.fsproj. netcoreapp1.1.paket.resolved created
 - /Users/h/dev/haf/expecto/Expecto.FsCheck/obj/Expecto.FsCheck.fsproj.net461.paket.resolved created
 - /Users/h/dev/haf/expecto/Expecto.FsCheck/obj/Expecto.FsCheck.fsproj. netstandard1.6.paket.resolved created
 - /Users/h/dev/haf/expecto/Expecto.Sample/obj/Expecto.Sample.fsproj.net461.paket.resolved created
 - /Users/h/dev/haf/expecto/Expecto.Sample/obj/Expecto.Sample.fsproj. netcoreapp1.1.paket.resolved created
 - /Users/h/dev/haf/expecto/Expecto.Tests/obj/Expecto.Tests.fsproj.net461.paket.resolved created
 - /Users/h/dev/haf/expecto/Expecto.Tests/obj/Expecto.Tests.fsproj. netcoreapp1.1.paket.resolved created
 - /Users/h/dev/haf/expecto/Expecto.Tests.CSharp/obj/Expecto.Tests.CSharp.csproj.net461.paket.resolved created
 - /Users/h/dev/haf/expecto/Expecto.Tests.CSharp/obj/Expecto.Tests.CSharp.csproj. netcoreapp1.1.paket.resolved created
 - /Users/h/dev/haf/expecto/testdata/Expecto.Focused.Tests/obj/Expecto.Focused.Tests.fsproj.net461.paket.resolved created
 - /Users/h/dev/haf/expecto/testdata/Expecto.Focused.Tests/obj/Expecto.Focused.Tests.fsproj. netcoreapp1.1.paket.resolved created
Performance:
 - Disk IO: 645 milliseconds
 - Runtime: 3 seconds
➜  expecto git:(feature/netstandard1.6) dotnet build
/Users/h/dev/haf/expecto/.paket/Paket.Restore.targets(86,5): warning : Detected a change ('target-framework 'netstandard1.6'') in the project file '/Users/h/dev/haf/expecto/Expecto/Expecto.fsproj', calling paket restore [/Users/h/dev/haf/expecto/Expecto/Expecto.fsproj]
/Users/h/dev/haf/expecto/.paket/Paket.Restore.targets(90,5): error : A paket file for the framework 'netstandard1.6' is missing. Please delete 'paket-files/paket.restore.cached' and call 'paket restore'. [/Users/h/dev/haf/expecto/Expecto/Expecto.fsproj]
^CAttempting to cancel the build...

From haf/expecto#197

@haf

This comment has been minimized.

Show comment
Hide comment
@haf

haf Sep 10, 2017

Member

This is a bug in paket, stemming from not trimming the values of the list of target frameworks:

     <TargetFrameworks>net461; netcoreapp1.1</TargetFrameworks>
   - /Users/h/dev/haf/expecto/testdata/Expecto.Focused.Tests/obj/Expecto.Focused.Tests.fsproj.net461.paket.resolved created
   - /Users/h/dev/haf/expecto/testdata/Expecto.Focused.Tests/obj/Expecto.Focused.Tests.fsproj. netcoreapp1.1.paket.resolved created
Member

haf commented Sep 10, 2017

This is a bug in paket, stemming from not trimming the values of the list of target frameworks:

     <TargetFrameworks>net461; netcoreapp1.1</TargetFrameworks>
   - /Users/h/dev/haf/expecto/testdata/Expecto.Focused.Tests/obj/Expecto.Focused.Tests.fsproj.net461.paket.resolved created
   - /Users/h/dev/haf/expecto/testdata/Expecto.Focused.Tests/obj/Expecto.Focused.Tests.fsproj. netcoreapp1.1.paket.resolved created

haf added a commit to teo-tsirpanis/expecto that referenced this issue Sep 10, 2017

@haf haf changed the title from Paket tells me to delete a file, still doesn't work to Multi-fw targeting w/ spaces aren't being trimmed for paket.restore.cached file gen Sep 10, 2017

@forki forki closed this in 9eb5cc7 Sep 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment