Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Our internal packages don't respect SemVer 'no leading zeros' #672

Closed
ascjones opened this issue Mar 3, 2015 · 3 comments
Closed

Our internal packages don't respect SemVer 'no leading zeros' #672

ascjones opened this issue Mar 3, 2015 · 3 comments

Comments

@ascjones
Copy link
Contributor

ascjones commented Mar 3, 2015

I just updated to 31.7 and our internal package versioning is not compatible with it, since we (incorrectly) have leading zeros as version part names.

3486c26

I can potentially fix this but it will take a while for the changes to propogate into our feed and across projects.

So I can tell people to stick on 31.6 until all our packages have removed the leading zeros, or we could add some kind of 'non-strict' semver option?

I suppose it's good to force us to be SemVer compatible, at the cost of some pain and management in the meantime. But on the other hand it might be nice not to break paket if you have any packages in the feed which don't respect SemVer 100%?

Not sure which approach is best - ideas?

@ascjones
Copy link
Contributor Author

ascjones commented Mar 3, 2015

Found this issue #289 which talks about this

@forki forki closed this as completed in ad17fbd Mar 3, 2015
@forki
Copy link
Member

forki commented Mar 3, 2015

our idea is to accept all existing nuget package versions. I reverted that stuff.

@ascjones
Copy link
Contributor Author

ascjones commented Mar 3, 2015

Okay well that also solves it. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants