Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide implementation methods #15

Closed
ovatsus opened this issue Jan 18, 2013 · 2 comments
Closed

Hide implementation methods #15

ovatsus opened this issue Jan 18, 2013 · 2 comments

Comments

@ovatsus
Copy link

ovatsus commented Jan 18, 2013

Csv

Method CsvFile.Parse: data:TextReader * sep:string option -> CsvFile is accessible, but it really shouldn't, because it returns CsvFile, and not the generated CsvType.
On other type providers, this problem doesn't exist because we usually replace the methods with others with the same signature in the derived generated class, but in the CsvProvider case, the generated Parse method doesn't have the sep parameter.
The ideal would be to make this method protected, but F# doesn't support that. Any other ideas to fix this?

WorldBank

There's a bunch of _Get methods that get the untyped data. We can hide them by putting them in an interface. Maybe that can also fix the problem with csv

@ovatsus
Copy link
Author

ovatsus commented Jan 24, 2013

By replacing the CsvFile.Parse with a constructor this can be solved, as the constructors of the real type will always be hidden. I'll submit a fix for this soon

@tpetricek
Copy link
Member

Sounds good to me, in fact, I do not know why the type used static method rather than constructor....

@ovatsus ovatsus closed this as completed Jan 25, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants