Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pluralization service #3

Closed
tpetricek opened this issue Dec 14, 2012 · 3 comments
Closed

Remove pluralization service #3

tpetricek opened this issue Dec 14, 2012 · 3 comments

Comments

@tpetricek
Copy link
Member

The NameUtils.fs file uses PluralizationService from System.Data.Entity.Design.PluralizationServices. This needs to be replaced with some other library or a custom implementation of English pluralization (in order to make the library compatible with the Client profile and more importantly also for portable profile and Mono).

@ovatsus
Copy link

ovatsus commented Dec 14, 2012

I've used a fairly comprehensive c# pluralizer I found some time ago on the web in one of my projects, and it worked farily well. I can try to dig it up, convert it to F# and submit a PR

@tpetricek
Copy link
Member Author

That would be great. I tried looking at the pluralization rules but gave up. If we need to get rid o it for portable profile sooner, feel free to replace the function with something simple (if s.EndsWith("s") then s + "es" else s + "s" will do the trick.)

@tpetricek
Copy link
Member Author

@forki pointed me to the pluralization code in FSharpx so we can reuse that. Please send any updates to FSharpx too!

tpetricek added a commit that referenced this issue Dec 15, 2012
#3 Remove pluralization service
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants