Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include source files in the Nuget package #185

Closed
bergmannjg opened this issue Oct 24, 2021 · 5 comments
Closed

Include source files in the Nuget package #185

bergmannjg opened this issue Oct 24, 2021 · 5 comments

Comments

@bergmannjg
Copy link

Description

Please include the source files in the Nuget package to make the library compatible with the dotnet Fable tool.

A corresponding rule can be added to the files block in the paket.template file.

@njlr
Copy link
Contributor

njlr commented Nov 27, 2021

I think this library is already (somewhat) Fable compatible? Which version are you using?

See: https://github.com/fsprojects/FSharpx.Collections/blob/master/src/FSharpx.Collections/FSharpx.Collections.fsproj#L15

@bergmannjg
Copy link
Author

I am using the nuget package version 3.0.1, which contains no fable folder.

The content itemgroup in FSharpx.Collections.fsproj is used by dotnet pack, but the nuget package is built with paket.

See: https://github.com/fsprojects/FSharpx.Collections/blob/master/build.fsx#L126

@njlr
Copy link
Contributor

njlr commented Nov 30, 2021

Ah I see!

This should fix it: #187

@bergmannjg
Copy link
Author

Thanks

@njlr
Copy link
Contributor

njlr commented Dec 1, 2021

Will take a while for the review, merge, release cycle to complete (I don't have permissions)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants