-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify "should throw" #20
Comments
@sergey-tihon Do you care about retro compatibility? (i.e. should I keep the old method and create a new one?). I am about to do this quick PR. |
@Evangelink Yes we care about backward compatibility. |
Ok cheers! I will have a look. |
@sergey-tihon There is a shouldFail method line 36 (don't know how to link a portion of code) in your commit that already satisfy @tpetricek request. Don't think it is worth doing a shouldThrow that will do the same thing (rename current method?). I can add a shouldFailWithMessage method that will also check the error message if wanted. |
Released in v2.2.0-beta1 |
Currently, you have to use
ignore
to discard the result in the function and you need to get type usingtypeof
:I think it would be neat if you could write just:
The text was updated successfully, but these errors were encountered: