No double votes #852
No double votes #852
Conversation
|
as voting is the most important feature of the whole system, i would prefer the second version and would add an explicit entry to the log file explaining from which user and for which course the double vote was recorded so that we could further investigate if any problems with the voting procedure should occur in the future. |
|
well, if we just log it, nobody is going to notice, just like in the last few years. |
|
then make it an error and send an email to the admins :) |
|
the button disable thing is ok? it might be slightly confusing, because when clicking the button, it gets disabled and the mouse pointer turns into that red forbidden-sign before the new page is loaded... |
|
maybe you could also change the button text to something like "Submitting questionnaire..."? then the user gets instant feedback, |
|
As discussed, the SuspiciousOperation gets logged and send to the admins by default, so there's no need for any additional logging. |
karyon
force-pushed
the
no_double_votes
branch
from
af9415e
to
8c6312e
Compare
|
🐇 |
karyon
force-pushed
the
no_double_votes
branch
from
8c6312e
to
b6a0288
Compare
fixes #850
first and third commits are alternatives. i like the first one better. the second one is more explicit, but both require the explaining comment, and with that, the first one is enough imo. what do you think?