Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential bug in fsspec.utils.infer_storage_options #45

Closed
andrii-ivaniuk opened this issue Mar 24, 2020 · 4 comments
Closed

Potential bug in fsspec.utils.infer_storage_options #45

andrii-ivaniuk opened this issue Mar 24, 2020 · 4 comments

Comments

@andrii-ivaniuk
Copy link

Hi,

I reported an issue for fsspec.
Here is a link: fsspec/filesystem_spec#256
Could you please take a look?

@martindurant
Copy link
Member

ping @hayesgb - should fsspec treat adl/bs URLs like it does s3/gcs? I suspect yes.

@hayesgb
Copy link
Collaborator

hayesgb commented Apr 3, 2020

It should, but we will need to coordinate an update. Currently, adlfs expects to receive both a "host" and a "path" key and they are concatenated within the library. If you were to just add them to the list of protocols, that would break.

Just let me know if you're going to make the update in fsspec.utils, and I can include an update in the next release.

@martindurant
Copy link
Member

OK, so @andrii-ivaniuk , the current behaviour is apparently as expected. Did you experience some problem from this?

@andrii-ivaniuk
Copy link
Author

@hayesgb Thanks for the response.
@martindurant No much problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants