Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameter anon ignored if set to False #467

Closed
adam-roughton opened this issue Apr 15, 2024 · 0 comments · Fixed by #468
Closed

Parameter anon ignored if set to False #467

adam-roughton opened this issue Apr 15, 2024 · 0 comments · Fixed by #468

Comments

@adam-roughton
Copy link
Contributor

The change introduced by #437 has meant that the anon parameter is effectively ignored if set to False: AzureBlobFileSystem(account_name, anon=False)

Should be something like this:

self.anon = anon if anon is not None else os.getenv("AZURE_STORAGE_ANON", "true").lower() not in [
    "false",
    "0",
    "f",
]

or perhaps more readable:

if anon is not None:
   self.anon = anon
else:
   self.anon = os.getenv("AZURE_STORAGE_ANON", "true").lower() not in [
      "false",
      "0",
      "f",
  ]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant