Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No root certs returned #4

Closed
antonellil opened this issue Apr 13, 2017 · 8 comments
Closed

No root certs returned #4

antonellil opened this issue Apr 13, 2017 · 8 comments
Assignees
Labels

Comments

@antonellil
Copy link

fszlin,

I love this library, its really great that it works with .Net Core. Thank you!

I had a question about dealing with Let's Encrypt certs. I am getting two certs returned but neither are the root, and it is failing to create the PfxBuilder because of this line:
https://github.com/fszlin/certes/blob/master/src/Certes/Pkcs/PfxBuilder.cs#L119

I have some more details about the issue here:
http://stackoverflow.com/questions/43381531/lets-encrypt-api-not-returning-root-cert

This is more of a question than an issue with the library I believe, but I would greatly appreciate any insight.

Thanks,
Louis

@fszlin
Copy link
Owner

fszlin commented Apr 13, 2017

Hi Louis, the issuers field should at least contains the certificates form Resources/Certificates.
There're two root certificates embedded, one for prod and one staging.

I am wondering if it is bad build~
Did you get it from nuget, and which version?

issuers

@fszlin fszlin self-assigned this Apr 13, 2017
@antonellil
Copy link
Author

antonellil commented Apr 13, 2017

Interesting, so that issuers variable is not dependent on my implementation? I will look into that. I am using a version of the code from this demo/tutorial https://github.com/Maarten88/rrod. It is located here: https://github.com/Maarten88/rrod/tree/master/lib. I believe it is the master source

@fszlin
Copy link
Owner

fszlin commented Apr 13, 2017

The LE server also returns intermediate certificates, which are being added to issuers. I think that’s why you got two certificates.
If building from source, just make sure the certificates are embedded in the assembly.

@antonellil
Copy link
Author

Thank you, that makes sense, I will check when I get home and report back.

@antonellil
Copy link
Author

fszlin, I know how to mark embedded resources using Visual Studio IDE, but I am searching on how to properly embed those certificates in my DotNet Core project using VS Code. I am assuming I need to add something to the .csproj? I am not sure

@antonellil
Copy link
Author

Also, I can confirm that those certificates are not being included. I logged the manifest resource names to the console and it is an empty array.

@antonellil
Copy link
Author

GOT IT! WOO!

I needed to embed with:
<ItemGroup> <EmbeddedResource Include="**/*.cer" /> </ItemGroup>

With everything changing in .Net Core from package.json to .csproj it was a little difficult to find

@antonellil
Copy link
Author

Thank you SO much fszlin!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants