New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use coursier to get dependencies #1144
Use coursier to get dependencies #1144
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1144 +/- ##
==========================================
- Coverage 69.74% 68.99% -0.76%
==========================================
Files 93 93
Lines 1408 1390 -18
Branches 38 39 +1
==========================================
- Hits 982 959 -23
- Misses 426 431 +5
Continue to review full report at Codecov.
|
If we want to get rid of |
Ohh i see. I first tried calling findUpdate from SbtAlg but i couldn't create it because it was creating a Circular Dependency. |
Oh, I didn't noticed that there would be circular dependency if |
RepoCacheAlg needs SbtAlg And UpdateAlg needs RepoCacheAlg |
I think we should split |
Superseded by #1209. |
closes #1139
What do you think @fthomas ?
Would this
(UpdateAlg.findUpdateUnderNewGroup)
in line 115 have to be reimplemented?