Skip to content
This repository has been archived by the owner on Jun 9, 2022. It is now read-only.

Feedback if link can't be displayed in an iFrame #13

Closed
seanmtracey opened this issue Nov 30, 2015 · 5 comments
Closed

Feedback if link can't be displayed in an iFrame #13

seanmtracey opened this issue Nov 30, 2015 · 5 comments
Assignees
Milestone

Comments

@seanmtracey
Copy link
Contributor

Currently, if a user tries to assign a web address to a screen that uses iFrames to display content (Chrome), and the site doesn't like being in an iFrame, we display a blank page until it either expires or someone notices and assigns content that does work.

What if, instead of sending the site of to be displayed willy-nilly, we request the headers of the site first and check if it's deployable? We could then alert the user in the admin panel that the content can't be displayed.

@AdaRoseCannon
Copy link
Contributor

We could do the check in the same request in which we get get the title and warn appropriately. But it wouldn't really work in carousels. Although the carousel doesn't seem to use the transformUrls module anymore is this now done somewhere else now?

@JakeChampion JakeChampion added this to the 2 milestone Dec 8, 2015
@JakeChampion JakeChampion modified the milestones: 3, 2 Dec 9, 2015
@seanmtracey
Copy link
Contributor Author

Currently under review in #47, still needs a little UI love.

@JakeChampion
Copy link
Contributor

#47 now merged, deployed to test. Picture of the work done to be added to this issue.

@JakeChampion
Copy link
Contributor

No Hover
no_hover
::hover
on_hover

@AdaRoseCannon
Copy link
Contributor

That bug appears to be fixed on screens-test, closing this issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants