Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logical restructure of elements #33

Open
sagikazarmark opened this issue Mar 25, 2015 · 3 comments
Open

Logical restructure of elements #33

sagikazarmark opened this issue Mar 25, 2015 · 3 comments

Comments

@sagikazarmark
Copy link
Contributor

There is a strange thing in list of elements, namely all of them are called "Input", but actually almost half of them are not. (I am referring to an element rendering into an input tag or not)

So I propose the following change: Rename the Input directory to Element and create an Input dir under it and move all real Input elements under it (with the necessary namespace changes of course).

Also, the inheritance should also respect this structure, eg. InputElement should only be used for real input elements.

@emlynwest
Copy link
Contributor

It's been on my todo for months, I need to clean up all of fieldset's internals.

@sagikazarmark
Copy link
Contributor Author

Do you have an actual todo list (with more than 'clean up internals')? We could split tasks up. I don't want to ruin your plans.

@emlynwest
Copy link
Contributor

Not really at the moment. My general thinking was just clearing up some of the duplicated code within the element classes/parent classes and getting the test coverage up.

@sagikazarmark sagikazarmark mentioned this issue Mar 26, 2015
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants