Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flowr should default to noTransactionAnimation #39

Closed
esoxjem opened this issue Feb 22, 2018 · 3 comments
Closed

flowr should default to noTransactionAnimation #39

esoxjem opened this issue Feb 22, 2018 · 3 comments

Comments

@esoxjem
Copy link

esoxjem commented Feb 22, 2018

Currently, flowr provides entry and exit custom transitions by default which causes us to use noTransactionAnimation() a lot. Instead we could switch the default behaviour. Thoughts @husseinala?

@husseinala
Copy link
Member

@esoxjem you actually don't need to use noTransactionAnimation() if you haven't provided default enter/exit animations by extending Flowr and overriding any of these methods getDefaultEnterAnimation(), getDefaultExitAnimation(), getDefaultPopEnterAnimation(), or getDefaultPopExitAnimation().

@esoxjem
Copy link
Author

esoxjem commented Feb 26, 2018

@ragdroid @chetdeva @initishbhatt looks it defaults to no animation 🤔 We don't need to add it. Good to close?

@chetdeva
Copy link

Yes 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants