Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better recovery mechanism from missing channel in compare-versions #109

Closed
eightfilms opened this issue Jul 20, 2022 · 1 comment
Closed
Labels
enhancement enhancement to a current feature

Comments

@eightfilms
Copy link
Contributor

Currently within compare-versions, if the script fails to download the latest channel published, it automatically tries to regenerate a channel with the latest versions, which isn't exactly desirable, since they may not be compatible. (source code)

Better way to handle this:

  1. Ensure that the error is a 404 error, and not due to other issues eg. connectivity issues
  2. Only if the error is a 404 error, we use the published incompatible versions to get the last published one, perhaps by querying the list of versions using GitHub API and comparing. Alternatively we could also have a separate folder where we publish all past compatible versions, similar to our incompatible versions. Then we can simply take the latest versions there. The 2nd method seems to be more straightforward.
@eightfilms eightfilms added the enhancement enhancement to a current feature label Jul 20, 2022
@eightfilms eightfilms self-assigned this Jul 25, 2022
@eightfilms eightfilms removed their assignment May 9, 2023
@mh6005
Copy link

mh6005 commented May 9, 2023

Ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement enhancement to a current feature
Projects
None yet
Development

No branches or pull requests

2 participants