Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect inconsistent versions between default toolchain and Forc manifest version #6

Closed
1 of 2 tasks
eightfilms opened this issue May 20, 2022 · 2 comments
Closed
1 of 2 tasks
Labels
enhancement enhancement to a current feature overrides

Comments

@eightfilms
Copy link
Contributor

eightfilms commented May 20, 2022

fuelup should be able to do both these things:

  • Set the default toolchain version.
  • Enable reading of the default toolchain version (so that forc can detect when you're using the wrong version that doesn't match what's configured in the manifest file).

As mentioned here, this would probably require some design decisions on what constitutes a stable toolchain and how we reconcile forc and fuel-core compatibility

Update:

With FuelLabs/sway#2405 now merged, we can detect inconsistent versions by matching with the minimum forc-version specified in the Forc.toml.

@adlerjohn adlerjohn added the enhancement enhancement to a current feature label May 20, 2022
@eightfilms
Copy link
Contributor Author

Since part 1 is already done with the introduction of the fuelup default command, I'm going to rename this issue and leave the 2nd one up as a task.

@eightfilms eightfilms changed the title Version management Detect inconsistent versions between default toolchain and Forc manifest version Sep 7, 2022
@sdankel
Copy link
Member

sdankel commented Nov 17, 2023

This is done using forc-toolchain.toml (overrides)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement enhancement to a current feature overrides
Projects
None yet
Development

No branches or pull requests

3 participants