New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 8 Maintainability, 1 Complexity issues in clickgen\main.py #12

Closed

ful1e5 opened this issue Sep 20, 2020 · 0 comments · Fixed by #21

Labels

wontfix

Owner

ful1e5 commented Sep 20, 2020

CodeFactor found multiple issues:

Unnecessary "elif" after "return"

clickgen_main_.py:80

Unnecessary "else" after "return"

clickgen_main_.py:59

Redefining argument with the local name 'config'

clickgen_main_.py:54

The if statement can be replaced with 'return bool(test)'

clickgen_main_.py:59

Comparison to False should be 'not expr'

clickgen_main_.py:116
clickgen_main_.py:116
clickgen_main_.py:80

Comparison to True should be just 'expr'

clickgen_main_.py:82

Complex Method

clickgen_main_.py:90-192

ful1e5 added the wontfix label

ful1e5 mentioned this issue

🚀 v1.1.8 #21

Merged

ful1e5 closed this as completed in #21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment