URL's in the description field were incorrectly translated. #124

Closed
objectx opened this Issue Sep 20, 2012 · 2 comments

2 participants

@objectx

I've installed "commit 70080cb" of fulcrum.

Today, I've put a URL like [Bing](http://www.bing.com/) in the description field. But rendered story contains:

<a href="http%3a//www.bing.com/">Bing</a>

This should be a <a href="http://www.bing.com/">Bing</a>

Regards.

@malclocke

Appears to be a double escaping problem with _.escape() and Markdown.Converter.

window.md.makeHtml('[foo](http:&#x2F;&#x2F;foo.com)')
"<p><a href="http%3a&#x2F;&#x2F;foo.com">foo</a></p>"

I'm pretty sure it's happening in Markdown.Converter somewhere.

@malclocke malclocke added a commit that closed this issue Oct 11, 2012
@malclocke malclocke Support escaped / characters in markdown URLs
Adds support to the pagedown Markdown converter for URLs where the
forward slashes in an absolute URL have been entity escaped (as they
are from Backbone.Model.escape()), e.g. http:&#x2F;&#x2F;example.com

Closes #124
d37f864
@malclocke malclocke closed this in d37f864 Oct 11, 2012
@malclocke

Well, that was quite hard to track down! Should be fixed in master as of d37f864

@dhruvasagar dhruvasagar added a commit that referenced this issue Apr 4, 2013
@malclocke malclocke Support escaped / characters in markdown URLs
Adds support to the pagedown Markdown converter for URLs where the
forward slashes in an absolute URL have been entity escaped (as they
are from Backbone.Model.escape()), e.g. http:&#x2F;&#x2F;example.com

Closes #124
cccf3cd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment