Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove custom (and leaky) checksum logic from pydust.build.zig #169

Closed
gatesn opened this issue Oct 2, 2023 · 2 comments · Fixed by #177
Closed

Remove custom (and leaky) checksum logic from pydust.build.zig #169

gatesn opened this issue Oct 2, 2023 · 2 comments · Fixed by #177

Comments

@gatesn
Copy link
Contributor

gatesn commented Oct 2, 2023

Now we have fixed the caching issues, we don't need this anymore
@robert3005
Copy link
Member

I am not certain it's no longer required. We just know that it was not enough

@gatesn
Copy link
Contributor Author

gatesn commented Oct 2, 2023

Either way we should fix the open file handle leaks, may as well test its effectiveness at the same time

@gatesn gatesn mentioned this issue Oct 4, 2023
Merged
gatesn added a commit that referenced this issue Oct 4, 2023
@gatesn
Fix resource leak (#177)
1572a72 
Fixes #169
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix resource leak spiraldb/ziggy-pydust
2 participants
@robert3005 @gatesn