Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refetchResources does not update columns properly in vertical resource view #100

Closed
caseyjhol opened this issue Jan 6, 2016 · 6 comments
Milestone

Comments

@caseyjhol
Copy link

It doesn't appear this was resolved by commit 7896125, although I'm sure it's related.

Demo: http://jsbin.com/natuxu/edit?js,output

In this demo, to simulate new resources every time the "refetchResources" button is clicked, the resources are now generated by a function that randomly selects one of 7 resources, and then removes it, only showing 6 resources.

The visible resources are updated every time the "refetchResources" button is clicked. You'll see this works fine in timeline view, but in vertical resource view, the correct columns are always "behind" where they should be, even if the correct events are being displayed. I've also named the events according to the resource they belong to, to make it easier to spot the issue (e.g. event A is in Auditorium A).

@arshaw
Copy link
Member

arshaw commented Jan 12, 2016

Ah yes, I was able to reproduce this while making the most recent release. I made acceptance tests here: https://github.com/fullcalendar/fullcalendar-scheduler/blob/v1.2.0/tests/column-rerendering.coffee#L20-L33

will get this fixed

@Efiware
Copy link

Efiware commented Feb 9, 2016

I experience this error too in more or less same scenario. Any idea when this will be fixed?

@arshaw
Copy link
Member

arshaw commented Feb 10, 2016

will be fixed in the next release. my goal is to have it released by monday

@arshaw arshaw added this to the v1.2.1 milestone Feb 16, 2016
@arshaw
Copy link
Member

arshaw commented Feb 18, 2016

updated jsbin to newest version, fixed the problem: http://jsbin.com/cavoxojiwe/1/edit?js,output

@arshaw
Copy link
Member

arshaw commented Feb 18, 2016

fix just released in v1.2.1

@arshaw arshaw closed this as completed Feb 18, 2016
@caseyjhol
Copy link
Author

Awesome - thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants