Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minTime/maxTime behaviour differentiates from calendar minTime/maxTime behaviour #112

Closed
MartijnWelker opened this issue Jan 15, 2016 · 11 comments
Milestone

Comments

@MartijnWelker
Copy link
Contributor

In the calendarDay view it is possible to set the minTime to "04:00:00" and the maxTime to "28:00:00", this results in a view from 4AM to 4AM the next day. Doing the same in the scheduler results in a view from 4AM to midnight the same day, is this intended behaviour ?

@arshaw
Copy link
Member

arshaw commented Jan 16, 2016

maxTime is currently not designed to work with values beyond 24:00:00. this would need to be taken into account. keeping this open to see if others are interested

@arshaw
Copy link
Member

arshaw commented Jan 16, 2016

oh, by "calendarDay" view, do you mean "agendaDay" ? i didn't realize this was possible in agendaDay

@MartijnWelker
Copy link
Contributor Author

Yes I meant agendaDay, I'll provide a plunkr but I'm on mobile now

@MartijnWelker
Copy link
Contributor Author

@fredhannouche
Copy link

I have exactly the same need, for a timeline view from 8am to 8am the next day.
Thanks

@arshaw
Copy link
Member

arshaw commented Jan 20, 2016

a workaround might involve customizing the view's duration to 24:00 and having its defaultDate be a date with time 04:00:00

@arshaw
Copy link
Member

arshaw commented Jan 20, 2016

but i see what u mean about difference in behavior. again, this is leveraging somewhat undefined API behavior. i'd rather have this done via some other view-customization settings.

@fredhannouche
Copy link

thanks for your answer, and actually, your proposal does not match with what I want to do.
do you think you can change the API in the coming days?

@arshaw
Copy link
Member

arshaw commented Feb 1, 2016

I can try to make this behavior match what is in agenda views. I would like to get it into the next Scheduler minor release, but I cannot guarantee when that'll be.

@mlaufer
Copy link

mlaufer commented Feb 1, 2016

+1

Would also appreciate this behaviour. I'm currently working with my own implementation where i calculate offsets to stay inside the 00:00-24:00 timespan and change the labels in the scheduler on my own

@arshaw arshaw added this to the v1.2.1 milestone Feb 17, 2016
@arshaw
Copy link
Member

arshaw commented Feb 18, 2016

just released in v1.2.1

minTime/maxTime's that are negative or beyond 24:00 should work well now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants