Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event time inconsistencies across different list views #3765

Open
paulking86 opened this issue Jul 25, 2017 · 4 comments
Open

Event time inconsistencies across different list views #3765

paulking86 opened this issue Jul 25, 2017 · 4 comments

Comments

@paulking86
Copy link

I have discovered what I believe to a be a bug with list views, and how event start and end times are displayed when an event spans into the first day of a different view. In other words, a multiple day event is displayed correctly in listWeek and listMonth views, but in the listDay view the times are inconsistent (because the whole event can not be shown in a single view). Not only that, but the last day of the event does not display any time whatsoever.

A working JS Bin example that demonstrates the above issues can be found here:
http://jsbin.com/dunaruw/edit?html,output

Consider the following event which takes place from Monday 7th August until Friday 11th August:

{
title: 'Event spanning multiple days',
start: '2017-08-07T08:00:00',
end: '2017-08-11T18:00:00'
}

When in a listWeek or listMonth view, FullCalendar correctly displays the event time on Monday 7th August as starting as 08:00 and finishing at 00:00. Tuesday, Wednesday and Thursday (8th August - 10th August) are correctly shown as all-day events. Friday 11th August starts at 00:00 and finishes at 18:00. This is the behaviour I would expect.

fullcalendar1

However in listDay view, the event time on Monday 7th of August is shown to start at 08:00 and finish at 23:59. Where's that minute gone!?

fullcalendar2

Tuesday, Wednesday and Thursday (8th August - 10th August) show correctly as all-day events. On Friday 11th August however, no event start or end times are displayed at all!

fullcalendar3

Now consider this event which takes place from Monday 14th August until Monday 21st August:

{
title: 'Event spanning over different weeks',
start: '2017-08-14T08:00:00',
end: '2017-08-21T18:00:00'
}

fullcalendar4

Interestingly in listWeek view, we are displaying the first day of the event as correctly starting at 08:00 and finishing at 00:00. We are no longer missing a minute! The same issue with the disappearing event times for the last date of the event remains however.

fullcalendar5

Finally, if we look at this event which takes place from Monday 28th August until Friday 1st September:

{
title: 'Event spanning over different months',
start: '2017-08-28T08:00:00',
end: '2017-09-01T18:00:00'
}

Just like with the listWeek view, the listMonth view will correctly display the first day of the event as starting at 08:00 and finishing at 00:00. We do however still have the problem of missing event times on the last day of the event.

fullcalendar6

What is interesting however, is that if we modify our events that span multiple weeks and multiple months to last just one day longer, the start and end times for the last day of the event will reappear! This indicates to me that this only happens when we span in to the next period of the current view by exactly one day. The reason this will always happen with the listDay view is because we (obviously) only ever have one day in the next period.

fullcalendar7

May I recommend the following:

  1. Fix an issue with the listDay view where the end time of the first day of an event that spans multiple days is set to 23:59 instead of 00:00 - therefore making it consistent with listWeek, listMonth and listYear.
  2. Ensure that start and end times for the last day of a multiple day event are displayed when the last day of the event spans in to the next period of a view by one day.

Thank you in advance for your help! 😄

@arshaw
Copy link
Member

arshaw commented Aug 10, 2017

thanks for the bug report. there's definitely something wonky going on.

@azampagl
Copy link

azampagl commented Apr 26, 2018

+1 this issue. On listDay view I have an event with the following start and end times:

start: "2018-05-01T23:35:00",
end: "2018-05-02T02:30:00"

On the day view for "2018-05-01" it shows the correct start time of "11:35pm", but on the day view for "2018-05-02" it shows the start time of "11:35pm" ALSO (which is wrong), when I would think it should be "12:00am" (since it rolled over and started the beginning of that day).

Version: 3.8.2

@agarfer1
Copy link

+1 on the issue, happening a similar problem on version 4.1. When having an event spanning multiple days starting at 00:00 if the event does not end at 00:00 the representation of the first day changes (event though it is a whole day).

In this pen the event that spans several days as a whole day is displayed correctly, however the other two are not (on the starting day): https://codepen.io/anon/pen/LoNjGj?editors=0110

The representation is also confusing on the Month view.

Thanks in advance!

@luisalvarado
Copy link

Yes, still shows weird for us here.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants