Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single day - allDay event not showing when time is specified #3854

Closed
criluc opened this issue Oct 2, 2017 · 10 comments
Closed

Single day - allDay event not showing when time is specified #3854

criluc opened this issue Oct 2, 2017 · 10 comments
Labels
Confirmed Event Model How event data is parsed and represented in models
Milestone

Comments

@criluc
Copy link

criluc commented Oct 2, 2017

I was wondering why fullcalendar (actually v. 3.5.1) doesn't show an event on the calendar if you set 'allDay:true' and the start and end attributes to the same day but with different time.

For example an event like this isn't shown:

{
title: 'All Day with time',
allDay: true,
start: new Date(2017, 10, 1, 10, 0, 0),
end: new Date(2017, 10, 1, 18, 0, 0)
}

I think fullcalendar should show the event even those I'm setting the event as an all day event but the difference beetwen the start and end time is less than 1 day.

Is it correct or is it a bug?

If I left out the time and I leave only the date with the same day it works correctly.

I've preparared a Reduced Test case on jsfiddle https://jsfiddle.net/yqs0jnhq/4/

Thanks!

@arshaw
Copy link
Member

arshaw commented Oct 23, 2017

it must be discarding the event as invalid because it must be stripping the time before doing validation, and if the start === end, it must be considering it invalid.

i tested to see if this is a regression from 3.5.* -> 3.6.* and it's not:
https://codepen.io/arshaw/pen/JrqbJv?editors=0010
https://codepen.io/arshaw/pen/qPGqjK?editors=0010

Will look into this more.

@arshaw arshaw added Confirmed Event Model How event data is parsed and represented in models labels Oct 23, 2017
@anoblg333
Copy link

I experienced the same issue. The regression was from 3.4.0 -> anything afterwards. In 3.4.0, I was able to specify allDay=true and specify an end date (now I have to make sure end is not specified for it show properly).

@fr0z3nfyr
Copy link

fr0z3nfyr commented Aug 1, 2018

Still facing this with latest release (stable).

EDIT: Sorry, it was my bad. I had mistakenly used allday property instead of allDay. It works fine for me at least in the three cases tested below (with allDay: true):

  1. Same start and end dates
  2. Different start and end dates
  3. Only start date but no end date

@sukhjindersingh
Copy link

Still facing this with latest release (stable).

EDIT: Sorry, it was my bad. I had mistakenly used allday property instead of allDay. It works fine for me at least in the three cases tested below (with allDay: true):

1. Same start and end dates

2. Different start and end dates

3. Only start date but no end date

Did you test it with time like below?

Start: 2018-10-29T12:00:00
End: 2018-10-29T13:00:00

@arshaw
Copy link
Member

arshaw commented Jan 1, 2019

@arshaw
Copy link
Member

arshaw commented Jan 10, 2019

fixed with 021af57. not yet released

@arshaw arshaw closed this as completed Jan 10, 2019
@arshaw
Copy link
Member

arshaw commented Jan 11, 2019

released in 3.10.0

@fr0z3nfyr
Copy link

Thanks for the update

@goosehub
Copy link

In case anybody finds their way to this issue for the same reason as I, it appears if you're using vue and fullcalendar 3.10.0, it will not be an issue on dev mode, but production mode causes the issue above.

@denism300
Copy link

denism300 commented Oct 9, 2023

I have a similar problem
Sample of event item:
{ id: 'some_id', title: 'some_title', start: startDate.toISOString().split('T')[0], end: endDate.toISOString().split('T')[0], editable: true, display: 'background', allDay: true }
and the last day of the event is not displayed on the calendar. How can this be fixed?
FullCalendar version 6.19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Confirmed Event Model How event data is parsed and represented in models
Projects
None yet
Development

No branches or pull requests

7 participants