Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[alpha2] ExtendedEventSourceInput events type does not allow EventSourceFunc #4342

Closed
baileyandy opened this issue Oct 15, 2018 · 5 comments
Closed

Comments

@baileyandy
Copy link

The documentation suggests an EventSourceFunc type value can be assigned to the events parameter when using Calendar::addEventSource, however, the current v4-alpha.2 code does not allow it.

Editing fullcalendar.d locally to events?: EventInput[] | EventSourceFunc (or adding @ts-ignore) allows my v4-alpha.1 code to compile.

I could submit a PR but wanted to check if this a regression or is the intention to switch to only allowing events?: EventInput[]?

@acerix
Copy link
Member

acerix commented Oct 16, 2018

Would you be able to post a runnable, stripped-down demonstration of the bug? Would really appreciate it because the time saved reproducing will be time spent fixing.

@baileyandy
Copy link
Author

baileyandy commented Nov 8, 2018

I saw a demo on a different issue concerning a TypeScript problem, so I've done the same.

My demo shows an error using the current code and an updated ExtendedEventSourceInput interface used in function call that TypeScript is happy with. The intellisense seems to start only when clicking inside the editor, so it may look ok on first load.

Hope this helps.

@arshaw arshaw added this to the v4 milestone Dec 26, 2018
@arshaw arshaw changed the title [v4-alpha.2] ExtendedEventSourceInput events type does not allow EventSourceFunc [alpha2] ExtendedEventSourceInput events type does not allow EventSourceFunc Dec 26, 2018
@arshaw
Copy link
Member

arshaw commented Dec 28, 2018

fixed this in the v4 branch at commit ab15b32

i'll comment again when this is released

@arshaw arshaw closed this as completed Dec 28, 2018
@arshaw
Copy link
Member

arshaw commented Jan 11, 2019

this has been addressed and released in 4.0.0-alpha.4

@baileyandy
Copy link
Author

Thanks! I can confirm, in the latest alpha release, this is working for me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants