Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fullcalendar slotLabelFormat does not change with Locale #4518

Closed
SushmaShashidhar opened this issue Feb 15, 2019 · 3 comments
Closed

Fullcalendar slotLabelFormat does not change with Locale #4518

SushmaShashidhar opened this issue Feb 15, 2019 · 3 comments

Comments

@SushmaShashidhar
Copy link

It is mentioned in the fullcalendar document here that slotLabelFormat takes Locale into account.
https://fullcalendar.io/docs/slotLabelFormat

But this is not working. If we set the Locale to German (de-DE), which has time format as H:mm (24 hours), the slot label still appears in 12 hours format which is the default (h:mm) .
This can be tested by setting locale to de-DE

@SushmaShashidhar SushmaShashidhar changed the title Fullcalendar slotLabelFormat does not work with Locale Fullcalendar slotLabelFormat does not change with Locale Feb 15, 2019
@acerix
Copy link
Member

acerix commented Feb 15, 2019

There's no locale named "de-DE", but the locale "de" shows the labels in 24 hour format in this demo:

https://fullcalendar.io/releases/fullcalendar/3.10.0/demos/locales.html

Would you be able to post a runnable, stripped-down demonstration of the bug? Would really appreciate it because the time saved reproducing will be time spent fixing.

@SushmaShashidhar
Copy link
Author

SushmaShashidhar commented Feb 19, 2019

Hi,

Please see below de-DE is one of the locales. I see quite a few locales are missing in the demo link you have shared.
http://docwiki.embarcadero.com/RADStudio/Rio/en/Language_Culture_Names,_Codes,_and_ISO_Values

@acerix
Copy link
Member

acerix commented Feb 19, 2019

The locales come from Moment.js, so if there is something specific to "de-DE" compared to the "de" locale you should submit it there, otherwise use "de" for the locale.

https://github.com/moment/moment/tree/master/locale

@acerix acerix closed this as completed Feb 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants