Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CustomButtonInput click argument type is incorrect #5432

Closed
kgilden opened this issue May 20, 2020 · 2 comments
Closed

CustomButtonInput click argument type is incorrect #5432

kgilden opened this issue May 20, 2020 · 2 comments
Assignees
Milestone

Comments

@kgilden
Copy link

kgilden commented May 20, 2020

It seems to me that the CustomButtonInput TypeScript type seems to be incorrect.

In v4.4.0 and v5.0.0-beta2 you can see that the first argument type is declared as HTMLElement, but in practice it seems to be MouseEvent.

Proof: https://repl.it/@kgilden/fullcalendar-5432

@acerix acerix changed the title Bug: CustomButtonInput click type seems incorrect CustomButtonInput click argument type is incorrect May 20, 2020
@acerix
Copy link
Member

acerix commented May 20, 2020

Thanks, confirmed.

@arshaw arshaw added this to the v5 milestone May 20, 2020
@arshaw arshaw removed this from the v5 milestone Jun 22, 2020
@arshaw arshaw added this to the next-minor milestone Jun 30, 2020
@arshaw arshaw closed this as completed in fa6b617 Jul 29, 2020
@arshaw
Copy link
Member

arshaw commented Aug 1, 2020

I made some changes to this in v5.2.0 (just released). The first argument will continue to be the MouseEvent, though the typescript definitions have been updated to reflect. A newly added second argument is the HTMLElement. I might have switched them if I didn't feel the need to keep this backward compatible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants